fix(animations): prevent the AsyncAnimationRenderer from calling the delegate when there is no element. #52570
+70
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
fix/animations-builder
branch
from
df80d6b
to
ff43ae7
Compare
JeanMeche
force-pushed
the
fix/animations-builder
branch
2 times, most recently
from
23fa504
to
ec0d5ba
Compare
JeanMeche
force-pushed
the
fix/animations-builder
branch
6 times, most recently
from
ce39d0c
to
819ece7
Compare
…delegate when there is no element. This happens when `issueAnimationCommand` is invoked fixes angular#52538
JeanMeche
force-pushed
the
fix/animations-builder
branch
from
819ece7
to
51e4810
Compare
jessicajaniuk
added
the
target: patch
jessicajaniuk
added
action: presubmit
|
This PR was merged into the repository by commit 5ee11a7. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…delegate when there is no element. (angular#52570) This happens when `issueAnimationCommand` is invoked fixes angular#52538 PR Close angular#52570
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…delegate when there is no element. (angular#52570) This happens when `issueAnimationCommand` is invoked fixes angular#52538 PR Close angular#52570
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…delegate when there is no element. (angular#52570) This happens when `issueAnimationCommand` is invoked fixes angular#52538 PR Close angular#52570
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…delegate when there is no element. (angular#52570) This happens when `issueAnimationCommand` is invoked fixes angular#52538 PR Close angular#52570
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when
issueAnimationCommandis invokedfixes #52538