fix(migrations): Add support for removing imports post migration #52763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
action: review
jessicajaniuk
force-pushed
the
remove-imports
branch
from
2128661
to
686688a
Compare
crisbeto
reviewed
Nov 10, 2023
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
jessicajaniuk
force-pushed
the
remove-imports
branch
from
686688a
to
b7f6065
Compare
jessicajaniuk
force-pushed
the
remove-imports
branch
2 times, most recently
from
bab9257
to
ca6eea0
Compare
crisbeto
approved these changes
Nov 13, 2023
packages/core/schematics/ng-generate/control-flow-migration/index.ts
Outdated
Show resolved
Hide resolved
jessicajaniuk
force-pushed
the
remove-imports
branch
from
ca6eea0
to
fe2420f
Compare
This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import.
jessicajaniuk
force-pushed
the
remove-imports
branch
from
fe2420f
to
ac195e4
Compare
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit 17adf0f. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 13, 2023
) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close #52763
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…ular#52763) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close angular#52763
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ular#52763) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close angular#52763
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ular#52763) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close angular#52763
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ular#52763) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close angular#52763
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes imports from component decorators and at the top of the files. It also checks to make sure CommonModule is not being used and removes that too.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?