-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): handle non-container environment injector cases for getEnvironmentInjectorProviders #52774
Closed
AleksanderBodurri
wants to merge
1
commit into
angular:main
from
AleksanderBodurri:devtools-get-providers-fix
Closed
fix(core): handle non-container environment injector cases for getEnvironmentInjectorProviders #52774
AleksanderBodurri
wants to merge
1
commit into
angular:main
from
AleksanderBodurri:devtools-get-providers-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderBodurri
added
area: core
Issues related to the framework runtime
target: patch
This PR is targeted for the next patch release
labels
Nov 10, 2023
Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation.
AleksanderBodurri
force-pushed
the
devtools-get-providers-fix
branch
from
November 10, 2023 08:07
f8a8333
to
6a01c7d
Compare
AleksanderBodurri
changed the title
fix(core): handle non-container environment injector cases
fix(core): handle non-container environment injector cases for getEnvironmentInjectorProviders
Nov 10, 2023
AndrewKushnir
approved these changes
Nov 10, 2023
jessicajaniuk
added
target: minor
This PR is targeted for the next minor release
target: patch
This PR is targeted for the next patch release
and removed
target: patch
This PR is targeted for the next patch release
target: minor
This PR is targeted for the next minor release
labels
Nov 13, 2023
This PR was merged into the repository by commit 6aef0f6. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 13, 2023
Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close #52774
2 tasks
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: core
Issues related to the framework runtime
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the
getEnvironmentInjectorProviders
function.This commit intends to fix this for two other cases, namely:
providers
field and lazy loading).It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation.