fix(migrations): Add missing support for ngForOf #52903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
action: review
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.
jessicajaniuk
force-pushed
the
migrate-ngforof
branch
from
f6a4b3b
to
1fa385a
Compare
JoostK
reviewed
Nov 14, 2023
| @@ -12,6 +12,12 @@ import {ElementCollector, ElementToMigrate, MigrateError, Result} from './types' | |||
| import {calculateNesting, getMainBlock, getOriginals, hasLineBreaks, parseTemplate, reduceNestingOffset} from './util'; | |||
|
|
|||
| export const ngfor = '*ngFor'; | |||
| export const nakedngfor = 'ngFor'; | |||
| const fors = [ | |||
There was a problem hiding this comment.
And also with you, @JoostK. :D
crisbeto
approved these changes
Nov 15, 2023
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit 8f5124e. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 15, 2023
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow. PR Close #52903
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow. PR Close angular#52903
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow. PR Close angular#52903
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow. PR Close angular#52903
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow. PR Close angular#52903
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?