Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cta clickability issue in adev homepage. #52905

Closed
wants to merge 1 commit into from

Conversation

SahulKola
Copy link
Contributor

@SahulKola SahulKola commented Nov 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Fix Clickability issue
  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

  • CTA is clickable after the page scroll.

Issue Number: fixes #52900

What is the new behavior?

  • added visibility: visible by default, and visibility: hidden property on page scroll

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@@ -142,7 +142,8 @@
display: inline-block;
padding: 7px;
opacity: 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove opacity here and for .adev-arrow and use only visibility. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use it for the transition.

@jessicajaniuk jessicajaniuk added the area: adev Angular.dev documentation label Nov 14, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 14, 2023
@@ -142,7 +142,8 @@
display: inline-block;
padding: 7px;
opacity: 0;
transition: opacity 0.5s linear;
visibility: hidden;
transition: opacity 0.5s linear, visibility 0.5s linear;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If transition doesn't work on visibility, we can remove it since we already have opacity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, visibility prevents from being able to interact with it. So we're fine.

Copy link

Deployed adev-preview for 4262663 to: https://ng-dev-previews-fw--pr-angular-angular-52905-adev-prev-lfcjn19y.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works. Looks great! Thank you!

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 25, 2024
@jessicajaniuk jessicajaniuk removed the request for review from jelbourn January 25, 2024 22:48
jessicajaniuk pushed a commit that referenced this pull request Jan 25, 2024
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit dfc6c8d.

rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
danieljancar pushed a commit to danieljancar/angular that referenced this pull request Jan 26, 2024
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
@SahulKola SahulKola deleted the fix-clickability branch February 9, 2024 10:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev Angular.dev documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learn Angular button is clickable even when not visible
5 participants