-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cta clickability issue in adev homepage. #52905
Conversation
@@ -142,7 +142,8 @@ | |||
display: inline-block; | |||
padding: 7px; | |||
opacity: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove opacity here and for .adev-arrow and use only visibility. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it for the transition.
@@ -142,7 +142,8 @@ | |||
display: inline-block; | |||
padding: 7px; | |||
opacity: 0; | |||
transition: opacity 0.5s linear; | |||
visibility: hidden; | |||
transition: opacity 0.5s linear, visibility 0.5s linear; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If transition doesn't work on visibility, we can remove it since we already have opacity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, visibility prevents from being able to interact with it. So we're fine.
Deployed adev-preview for 4262663 to: https://ng-dev-previews-fw--pr-angular-angular-52905-adev-prev-lfcjn19y.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this works. Looks great! Thank you!
This PR was merged into the repository by commit dfc6c8d. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: fixes #52900
What is the new behavior?
visibility: visible
by default, andvisibility: hidden
property on page scrollDoes this PR introduce a breaking change?
Other information