fix(core): reset cached scope for components that were overridden using TestBed #52916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
area: testing
atscott
approved these changes
Nov 14, 2023
AndrewKushnir
added
action: presubmit
AndrewKushnir
force-pushed
the
fix_52817
branch
from
511cc24
to
f559ca0
Compare
…ng TestBed Currently, when a component is overriden using `TestBed.overrideComponent`, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation. Resolves angular#52817.
AndrewKushnir
force-pushed
the
fix_52817
branch
from
f559ca0
to
ef3af9b
Compare
AndrewKushnir
added
action: merge
|
Thx |
|
This PR was merged into the repository by commit ee892ee. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 15, 2023
…ng TestBed (#52916) Currently, when a component is overriden using `TestBed.overrideComponent`, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation. Resolves #52817. PR Close #52916
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…ng TestBed (angular#52916) Currently, when a component is overriden using `TestBed.overrideComponent`, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation. Resolves angular#52817. PR Close angular#52916
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ng TestBed (angular#52916) Currently, when a component is overriden using `TestBed.overrideComponent`, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation. Resolves angular#52817. PR Close angular#52916
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ng TestBed (angular#52916) Currently, when a component is overriden using `TestBed.overrideComponent`, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation. Resolves angular#52817. PR Close angular#52916
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ng TestBed (angular#52916) Currently, when a component is overriden using `TestBed.overrideComponent`, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation. Resolves angular#52817. PR Close angular#52916
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a component is overridden using
TestBed.overrideComponent, Angular retains calculated scope for that component (a set of components and directives used within a component). This may cause stale information to be used in tests in some cases. This commit updates the logic to reset overridden component scope, so it gets re-computed during the next invocation.Resolves #52817.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?