Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): handle local refs when getDeferBlocks is invoked in tests #52973

Closed
wants to merge 1 commit into from
Closed

fix(core): handle local refs when getDeferBlocks is invoked in tests #52973

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit fixes an issue where having elements with local refs in some cases causes JS exception.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
fix(core): handle local refs when getDeferBlocks is invoked in tests
683e68a 
This commit fixes an issue where having elements with local refs in some cases causes JS exception.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: defer Issues related to @defer blocks. labels Nov 16, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 16, 2023
jessicajaniuk
jessicajaniuk approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2023
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 16, 2023
@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit 1ce31d8.

AndrewKushnir added a commit that referenced this pull request Nov 16, 2023
@AndrewKushnir
fix(core): handle local refs when getDeferBlocks is invoked in tests (
31a1575 
#52973)

This commit fixes an issue where having elements with local refs in some cases causes JS exception.

PR Close #52973
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@AndrewKushnir @tbondwilkinson
fix(core): handle local refs when getDeferBlocks is invoked in tests (
860aa25 
angular#52973)

This commit fixes an issue where having elements with local refs in some cases causes JS exception.

PR Close angular#52973
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 17, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@AndrewKushnir @ChellappanRajan
fix(core): handle local refs when getDeferBlocks is invoked in tests (
597d8e0 
angular#52973)

This commit fixes an issue where having elements with local refs in some cases causes JS exception.

PR Close angular#52973
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@AndrewKushnir @rlmestre
fix(core): handle local refs when getDeferBlocks is invoked in tests (
ecf3bd6 
angular#52973)

This commit fixes an issue where having elements with local refs in some cases causes JS exception.

PR Close angular#52973
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@AndrewKushnir @amilamen
fix(core): handle local refs when getDeferBlocks is invoked in tests (
c577e6d 
angular#52973)

This commit fixes an issue where having elements with local refs in some cases causes JS exception.

PR Close angular#52973
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: defer Issues related to @defer blocks. target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewKushnir @jessicajaniuk