fix(core): inherit host directives #52992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
removed
the
action: global presubmit
|
I realized that this will need a bit more work on the compiler side to properly support template type checking. Putting it back to draft. |
crisbeto
force-pushed
the
51203/host-directives-inherit
branch
from
a20048a
to
bc48a49
Compare
|
Okay, now everything should be covered. |
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings. Fixes angular#51203.
crisbeto
force-pushed
the
51203/host-directives-inherit
branch
from
bc48a49
to
c4f4eb5
Compare
jessicajaniuk
removed
the
action: review
|
This PR was merged into the repository by commit c7c7ea9. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 20, 2023
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings. Fixes angular#51203. PR Close angular#52992
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings. Fixes angular#51203. PR Close angular#52992
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings. Fixes angular#51203. PR Close angular#52992
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings. Fixes angular#51203. PR Close angular#52992
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings.
Fixes #51203.