fix(migrations): control flow migration omnibus bugfixes #53076

jessicajaniuk · 2023-11-20T22:28:04Z

This is an omnibus of minor formatting and bugfixes to the control flow migration:

preserves leading spaces on inline templates
Better handles self closing tags with or without the /
overall formatting fixes
adds support for *ngFor="x of y; template: templateName"
fixes a bug with building conditions when trailing semicolons are present for NgIf with else and then else
handles cases of transplanted views
Fixes loss of let variable on NgIf else and if then else
Handles case of ngif else or if then else not using semicolon separators
Ensures common module is removed from classes using templateUrl

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix

Does this PR introduce a breaking change?

Yes
No

JoostK · 2023-11-21T19:17:51Z

packages/core/schematics/test/control_flow_migration_spec.ts

+
+      const expected = [
+        `@for (item of items; track item) {`,
+        `  <ng-container *ngTemplateOutlet="itemTemplate; context: {$implicit: item}">`,


Might be a bit tricky, but NgTemplateOutlet or CommonModule needs to be imported for this to work.

Agree, though I think this use case is rare enough that if they have to manually add that in, it should be fine for the purposes of the migration.

packages/core/schematics/test/control_flow_migration_spec.ts

packages/core/schematics/ng-generate/control-flow-migration/index.ts

This fix preserves leading indents in inline templates and also adds better handling for self closing tags

This adds code to cover the rare use case of an ngFor with a template param. fixes: angular#53068

Common module removal would not happen when a component used a templateUrl due to the checks being in separate files. This change passes the removal analysis back to the original source file to safely remove CommonModule.

jessicajaniuk · 2023-11-27T18:29:28Z

Caretaker Note: This requires a patch CL to land when this syncs in.

packages/core/schematics/ng-generate/control-flow-migration/types.ts

This makes sure colons after else and then cases get migrated properly. fixes: angular#53150

…53076) Common module removal would not happen when a component used a templateUrl due to the checks being in separate files. This change passes the removal analysis back to the original source file to safely remove CommonModule. PR Close #53076

This makes sure colons after else and then cases get migrated properly. fixes: #53150 PR Close #53076

…53076) This adds code to cover the rare use case of an ngFor with a template param. fixes: #53068 PR Close #53076

…53076) Common module removal would not happen when a component used a templateUrl due to the checks being in separate files. This change passes the removal analysis back to the original source file to safely remove CommonModule. PR Close #53076

This makes sure colons after else and then cases get migrated properly. fixes: #53150 PR Close #53076

This fix preserves leading indents in inline templates and also adds better handling for self closing tags PR Close angular#53076

…ngular#53076) This adds code to cover the rare use case of an ngFor with a template param. fixes: angular#53068 PR Close angular#53076

…ngular#53076) Common module removal would not happen when a component used a templateUrl due to the checks being in separate files. This change passes the removal analysis back to the original source file to safely remove CommonModule. PR Close angular#53076

…#53076) This makes sure colons after else and then cases get migrated properly. fixes: angular#53150 PR Close angular#53076

This fix preserves leading indents in inline templates and also adds better handling for self closing tags PR Close angular#53076

…ngular#53076) This adds code to cover the rare use case of an ngFor with a template param. fixes: angular#53068 PR Close angular#53076

…ngular#53076) Common module removal would not happen when a component used a templateUrl due to the checks being in separate files. This change passes the removal analysis back to the original source file to safely remove CommonModule. PR Close angular#53076

…#53076) This makes sure colons after else and then cases get migrated properly. fixes: angular#53150 PR Close angular#53076

angular-automatic-lock-bot · 2023-12-29T00:07:50Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}