Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations): remove setting that removes comments in CF migration #53350

Closed
wants to merge 1 commit into from
Closed

fix(migrations): remove setting that removes comments in CF migration #53350

wants to merge 1 commit into from
+1 −7

Conversation

jessicajaniuk
Copy link
Contributor

This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that. However in component imports, it is not safe to remove comments as they could be load bearing for some.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

Sorry, something went wrong.

@thePunderWoman
fix(migrations): remove setting that removes comments in CF migration
Loading
Loading status checks…
0069bd1 
This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that.
However in component imports, it is not safe to remove comments as they could be load bearing for some.
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update` migrations labels Dec 4, 2023
@ngbot ngbot bot modified the milestone: Backlog Dec 4, 2023
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Dec 5, 2023

This PR was merged into the repository by commit 9834fd2.

@dylhunn dylhunn closed this in 9834fd2 Dec 5, 2023
dylhunn pushed a commit that referenced this pull request Dec 5, 2023
@thePunderWoman @dylhunn
fix(migrations): remove setting that removes comments in CF migration (…
0db75ab 
…#53350)

This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that.
However in component imports, it is not safe to remove comments as they could be load bearing for some.

PR Close #53350
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@thePunderWoman @tbondwilkinson
fix(migrations): remove setting that removes comments in CF migration (…
c082cce 
…angular#53350)

This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that.
However in component imports, it is not safe to remove comments as they could be load bearing for some.

PR Close angular#53350
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 5, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@thePunderWoman @ChellappanRajan
fix(migrations): remove setting that removes comments in CF migration (…
a7e2242 
…angular#53350)

This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that.
However in component imports, it is not safe to remove comments as they could be load bearing for some.

PR Close angular#53350
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @rlmestre
fix(migrations): remove setting that removes comments in CF migration (…
e572221 
…angular#53350)

This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that.
However in component imports, it is not safe to remove comments as they could be load bearing for some.

PR Close angular#53350
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @amilamen
fix(migrations): remove setting that removes comments in CF migration (…

Verified

This commit was signed with the committer’s verified signature.
amilamen Ezéchiel Amen AGBLA
GPG key ID: 8478BC84CA21FC35
Verified
Learn about vigilant mode
d9bde0d 
…angular#53350)

This setting was added to prevent comment duplication, since the TS AST printer includes prior line comments as part of a given line with no way to really avoid that.
However in component imports, it is not safe to remove comments as they could be load bearing for some.

PR Close angular#53350
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessicajaniuk @dylhunn @crisbeto @thePunderWoman