Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch only] Cherry-pick control flow diagnostic into patch branch #53387

Closed
wants to merge 5 commits into from
Closed

[Patch only] Cherry-pick control flow diagnostic into patch branch #53387

wants to merge 5 commits into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 6, 2023

Cherry-pick the changes from #53190 and #53311 into the patch branch.

@crisbeto
refactor(compiler): expose utility for creating CSS selectors from AS…
8d64dcd 
…T nodes

When doing directive matching in the compiler, we need to be able to create a selector from an AST node. We already have the utility, but these changes simplify the public API and expose it so it can be used in `compiler-cli`.
@crisbeto
refactor(compiler-cli): expose ng-content selectors and preserveWhite…
dcdd537 
…spaces during template type checking

These changes expose the `ngContentSelectors` and `preserveWhitespaces` metadata to the TCB so they can be used in the next commit to implement a new diagnostic.
@crisbeto
test(core): add tests for control flow content projection with ng-con…
6740e19 
…tainer

The control flow projection diagnostic will mention `ng-container` as a workaround for projection multiple nodes. These changes add a couple of tests to ensure that the approach works.
@crisbeto
fix(compiler-cli): add diagnostic for control flow that prevents cont…
b236c12 
…ent projection

This is a follow-up to the fix from angular#52414. It adds a diagnostic that will tell users when a control flow is preventing its direct descendants from being projected into a specific component slot.
@crisbeto
fix(compiler-cli): add compiler option to disable control flow conten…
b0aa4a0 
…t projection diagnostic

These changes add an option to the `extendedDiagnostics` field that allows the check from angular#53190 to be disabled. This is a follow-up based on a recent discussion.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 6, 2023
@pullapprove pullapprove bot requested a review from dylhunn December 6, 2023 13:53
pkozlowski-opensource
pkozlowski-opensource approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

jessicajaniuk
jessicajaniuk approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 6, 2023
@crisbeto crisbeto changed the title Cherry-pick control flow diagnostic into patch branch [Patch only] Cherry-pick control flow diagnostic into patch branch Dec 6, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Dec 6, 2023

This PR was merged into the repository by commit 66ecf4c.

@dylhunn dylhunn closed this Dec 6, 2023
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@crisbeto @dylhunn
refactor(compiler): expose utility for creating CSS selectors from AS…
cbbd9f3 
…T nodes (#53387)

When doing directive matching in the compiler, we need to be able to create a selector from an AST node. We already have the utility, but these changes simplify the public API and expose it so it can be used in `compiler-cli`.

PR Close #53387
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@crisbeto @dylhunn
refactor(compiler-cli): expose ng-content selectors and preserveWhite…
ec9cc38 
…spaces during template type checking (#53387)

These changes expose the `ngContentSelectors` and `preserveWhitespaces` metadata to the TCB so they can be used in the next commit to implement a new diagnostic.

PR Close #53387
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@crisbeto @dylhunn
test(core): add tests for control flow content projection with ng-con…
cfa80dc 
…tainer (#53387)

The control flow projection diagnostic will mention `ng-container` as a workaround for projection multiple nodes. These changes add a couple of tests to ensure that the approach works.

PR Close #53387
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@crisbeto @dylhunn
fix(compiler-cli): add diagnostic for control flow that prevents cont…
74e6ce5 
…ent projection (#53387)

This is a follow-up to the fix from #52414. It adds a diagnostic that will tell users when a control flow is preventing its direct descendants from being projected into a specific component slot.

PR Close #53387
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@crisbeto @dylhunn
fix(compiler-cli): add compiler option to disable control flow conten…
66ecf4c 
…t projection diagnostic (#53387)

These changes add an option to the `extendedDiagnostics` field that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.

PR Close #53387
@anisabboud anisabboud mentioned this pull request Dec 10, 2023
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alxhub alxhub alxhub approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crisbeto @dylhunn @pkozlowski-opensource @alxhub @jessicajaniuk