#2 Signal inputs

goldens/public-api/core/index.md

@@ -6,6 +6,7 @@
 
 import { Observable } from 'rxjs';
 import { SIGNAL } from '@angular/core/primitives/signals';
+import { SignalNode } from '@angular/core/primitives/signals';
 import { Subject } from 'rxjs';
 import { Subscription } from 'rxjs';
 
@@ -874,10 +875,14 @@ export interface InputDecorator {
 }
 
 // @public
-export type InputSignal<ReadT, WriteT = ReadT> = Signal<ReadT> & {
+export interface InputSignal<ReadT, WriteT = ReadT> extends Signal<ReadT> {
+    // (undocumented)
     [ɵINPUT_SIGNAL_BRAND_READ_TYPE]: ReadT;
+    // (undocumented)
     [ɵINPUT_SIGNAL_BRAND_WRITE_TYPE]: WriteT;
-};
+    // (undocumented)
+    [SIGNAL]: InputSignalNode<ReadT, WriteT>;
+}
 
 // @public
 export function isDevMode(): boolean;

goldens/public-api/core/primitives/signals/index.md

@@ -95,6 +95,9 @@ export function setThrowInvalidWriteToSignalError(fn: () => never): void;
 // @public
 export const SIGNAL: unique symbol;
 
+// @public (undocumented)
+export const SIGNAL_NODE: SignalNode<unknown>;
+
 // @public (undocumented)
 export interface SignalGetter<T> extends SignalBaseGetter<T> {
     // (undocumented)
@@ -106,8 +109,6 @@ export function signalMutateFn<T>(node: SignalNode<T>, mutator: (value: T) => vo
 
 // @public (undocumented)
 export interface SignalNode<T> extends ReactiveNode {
-    // (undocumented)
-    readonly [SIGNAL]: SignalNode<T>;
     // (undocumented)
     equal: ValueEqualityFn<T>;
     // (undocumented)

packages/compiler-cli/src/ngtsc/typecheck/test/input_signal_diagnostics_spec.ts

@@ -399,6 +399,79 @@ runInEachFileSystem(() => {
               `TestComponent.html(3, 63): Type 'number' is not assignable to type 'null'.`,
             ],
           },
+          // differing Write and ReadT
+          {
+            id: 'differing WriteT and ReadT, superset union, valid binding',
+            inputs: {
+              bla: {
+                type: 'InputSignal<boolean, boolean|string>',
+                isSignal: true,
+              },
+            },
+            template: `<div dir bla="string value">`,
+            expected: [],
+          },
+          {
+            id: 'differing WriteT and ReadT, superset union, invalid binding',
+            inputs: {
+              bla: {
+                type: 'InputSignal<boolean, boolean|string>',
+                isSignal: true,
+              },
+            },
+            template: `<div dir [bla]="2">`,
+            expected: [
+              `TestComponent.html(1, 11): Type '2' is not assignable to type 'string | boolean'.`,
+            ],
+          },
+          {
+            id: 'differing WriteT and ReadT, divergent, valid binding',
+            inputs: {
+              bla: {
+                type: 'InputSignal<boolean, string>',
+                isSignal: true,
+              },
+            },
+            template: `<div dir bla="works">`,
+            expected: [],
+          },
+          {
+            id: 'differing WriteT and ReadT, divergent, invalid binding',
+            inputs: {
+              bla: {
+                type: 'InputSignal<boolean, string>',
+                isSignal: true,
+              },
+            },
+            template: `<div dir [bla]="true">`,
+            expected: [
+              `TestComponent.html(1, 11): Type 'boolean' is not assignable to type 'string'.`,
+            ],
+          },
+          {
+            id: 'differing WriteT and ReadT, generic ctor inference',
+            inputs: {
+              bla: {
+                type: 'InputSignal<string, T>',
+                isSignal: true,
+              },
+            },
+            extraDirectiveMembers: [
+              `tester: {t: T, blaValue: never} = null!`,
+            ],
+            directiveGenerics: '<T>',
+            template: `
+              <div dir [bla]="prop" #ref="dir"
+                   (click)="ref.tester = {t: 0, blaValue: ref.bla()}">`,
+            component: `prop: HTMLElement = null!`,
+            expected: [
+              // This verifies that the `ref.tester.t` is correctly inferred to be `HTMLElement`.
+              `TestComponent.html(3, 46): Type 'number' is not assignable to type 'HTMLElement'.`,
+              // This verifies that the `bla` input value is still a `string` when accessed.
+              `TestComponent.html(3, 59): Type 'string' is not assignable to type 'never'.`,
+            ],
+          },
+          // TODO(devversion): inline constructor test
         ];
 
     for (const c of bindingCases) {

packages/compiler-cli/test/compliance/linked/BUILD.bazel

@@ -24,10 +24,6 @@ jasmine_node_test(
         "//packages/compiler-cli/test/compliance/test_cases",
     ],
     shard_count = 2,
-    tags = [
-        # TODO: renable this test after debugging the issues related to babel updates
-        "manual",
-    ],
     deps = [
         ":test_lib",
     ],

packages/compiler-cli/test/compliance/linked/linked_compile_spec.ts

@@ -17,7 +17,10 @@ import {ComplianceTest} from '../test_helpers/get_compliance_tests';
 import {parseGoldenPartial} from '../test_helpers/golden_partials';
 import {runTests} from '../test_helpers/test_runner';
 
-runTests('linked compile', linkPartials);
+runTests('linked compile', linkPartials, {
+  // TODO: Remove when https://github.com/angular/angular/issues/51647 is resolved.
+  skipMappingChecks: true,
+});
 
 /**
  * Link all the partials specified in the given `test`.

packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/lifecycle_hooks/lifecycle_hooks_lifecycle_comp_def.js

@@ -1,7 +1,7 @@
 LifecycleComp.ɵcmp = /*@__PURE__*/ $r3$.ɵɵdefineComponent({
   type: LifecycleComp,
   selectors: [["lifecycle-comp"]],
-  inputs: {nameMin: ["name", "nameMin"]},
+  inputs: {nameMin: [$r3$.ɵɵInputFlags.None, "name", "nameMin"]},
   features: [$r3$.ɵɵNgOnChangesFeature],
   decls: 0,
   vars: 0,

packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/ng_modules/declarations_jit_mode.js

@@ -15,5 +15,5 @@ FooModule.ɵinj = /*@__PURE__*/ $i0$.ɵɵdefineInjector({});
   (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassMetadata(FooModule, [{
     type: NgModule,
     args: [{ declarations: [FooComponent, BarDirective, QuxPipe], bootstrap: [FooComponent] }]
-  }], null, null)
+  }], null, null);
 })();

packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/ng_modules/forward_refs.js

@@ -2,14 +2,12 @@ export function provideModule() {
     return { ngModule: ForwardModule };
 }
 …
-class TestModule {}
+export class TestModule {}
 TestModule.ɵfac = function TestModule_Factory(t) { return new (t || TestModule)(); };
-TestModule.ɵmod = /*@__PURE__*/ i0.ɵɵdefineNgModule({ type: TestModule, imports: function () { return [ForwardModule]; } });
+TestModule.ɵmod = /*@__PURE__*/ i0.ɵɵdefineNgModule({ type: TestModule, imports: () => [ForwardModule] });
 TestModule.ɵinj = /*@__PURE__*/ i0.ɵɵdefineInjector({ imports: [provideModule()] });
-export { TestModule };
 …
-class ForwardModule {}
+export class ForwardModule {}
 ForwardModule.ɵfac = function ForwardModule_Factory(t) { return new (t || ForwardModule)(); };
 ForwardModule.ɵmod = /*@__PURE__*/ i0.ɵɵdefineNgModule({ type: ForwardModule });
-ForwardModule.ɵinj = /*@__PURE__*/ i0.ɵɵdefineInjector({});
-export { ForwardModule };
+ForwardModule.ɵinj = /*@__PURE__*/ i0.ɵɵdefineInjector({});

packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/ng_modules/imports_exports_jit_mode.js

@@ -1,8 +1,7 @@
-class AModule {}
+export class AModule {}
 AModule.ɵfac = function AModule_Factory(t) { return new (t || AModule)(); };
 AModule.ɵmod = /*@__PURE__*/ i0.ɵɵdefineNgModule({ type: AModule, declarations: [A1Component, A2Component], exports: [A1Component, A2Component] });
 AModule.ɵinj = /*@__PURE__*/ i0.ɵɵdefineInjector({});
-export { AModule };
 …
 (() => {
   (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassMetadata(AModule, [{
@@ -11,12 +10,10 @@ export { AModule };
   }], null, null);
 })();
 …
-
-class BModule {}
+export class BModule {}
 BModule.ɵfac = function BModule_Factory(t) { return new (t || BModule)(); };
 BModule.ɵmod = /*@__PURE__*/ i0.ɵɵdefineNgModule({ type: BModule, declarations: [B1Component, B2Component], exports: [AModule] });
 BModule.ɵinj = /*@__PURE__*/ i0.ɵɵdefineInjector({ imports: [AModule] });
-export { BModule };
 …
 (() => {
   (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassMetadata(BModule, [{
@@ -25,12 +22,10 @@ export { BModule };
   }], null, null);
 })();
 …
-
-class AppModule {}
+export class AppModule {}
 AppModule.ɵfac = function AppModule_Factory(t) { return new (t || AppModule)(); };
 AppModule.ɵmod = /*@__PURE__*/ i0.ɵɵdefineNgModule({ type: AppModule, imports: [BModule] });
 AppModule.ɵinj = /*@__PURE__*/ i0.ɵɵdefineInjector({ imports: [BModule] });
-export { AppModule };
 …
 (() => {
   (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassMetadata(AppModule, [{