fix(router): Should not freeze original object used for route data #53635
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes angular#53632
atscott
added
action: review
crisbeto
approved these changes
Dec 19, 2023
atscott
added
action: merge
|
This PR was merged into the repository by commit 502f300. |
atscott
added a commit
that referenced
this pull request
Dec 19, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#53635) This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes angular#53632 PR Close angular#53635
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ngular#53635) This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes angular#53632 PR Close angular#53635
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
…ngular#53635) This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes angular#53632 PR Close angular#53635
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ngular#53635) This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes angular#53632 PR Close angular#53635
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in 3278966 where the new code fails to copy the data object when not inheriting data.
fixes #53632