-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-server): Do not delete global Event #53659
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a hack that deletes `Event` from the global context when using domino. Instead, it sets the global event to domino's implementation of `Event`.
AndrewKushnir
approved these changes
Jan 4, 2024
atscott
added
area: testing
Issues related to Angular testing features, such as TestBed
target: patch
This PR is targeted for the next patch release
labels
Jan 4, 2024
devversion
approved these changes
Jan 4, 2024
This PR was merged into the repository by commit f4bd5a3. |
atscott
added a commit
that referenced
this pull request
Jan 4, 2024
This commit removes a hack that deletes `Event` from the global context when using domino. Instead, it sets the global event to domino's implementation of `Event`. PR Close #53659
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit removes a hack that deletes `Event` from the global context when using domino. Instead, it sets the global event to domino's implementation of `Event`. PR Close angular#53659
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
This commit removes a hack that deletes `Event` from the global context when using domino. Instead, it sets the global event to domino's implementation of `Event`. PR Close angular#53659
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
This commit removes a hack that deletes `Event` from the global context when using domino. Instead, it sets the global event to domino's implementation of `Event`. PR Close angular#53659
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
This commit removes a hack that deletes `Event` from the global context when using domino. Instead, it sets the global event to domino's implementation of `Event`. PR Close angular#53659
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: testing
Issues related to Angular testing features, such as TestBed
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a hack that deletes
Event
from the global context when using domino. Instead, it sets the global event to domino's implementation ofEvent
.The "Trick to avoid Event patching" links to a state in the repository that is 6(!) years old:
angular/packages/platform-browser/src/dom/events/dom_events.ts
Lines 112 to 132 in 7cf5e95