fix(common): The date pipe should return ISO format for week and week… #53879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Jan 11, 2024
JeanMeche
force-pushed
the
fix/week-iso
branch
from
33edad8
to
61db1f3
Compare
alxhub
approved these changes
Jan 12, 2024
alxhub
added
action: global presubmit
|
Caretaker: this should get a TGP :) |
dylhunn
added
the
area: common
jessicajaniuk
requested review from
AndrewKushnir
and removed request for
AndrewKushnir
jessicajaniuk
added
the
target: patch
AndrewKushnir
approved these changes
Jan 26, 2024
|
Caretaker note: this PR still requires TGP, it's not yet ready for merge. |
|
It looks like there's a few legitimate failing targets. Adding |
JeanMeche
force-pushed
the
fix/week-iso
branch
from
61db1f3
to
d1c0c95
Compare
jessicajaniuk
added
action: cleanup
…-year as intended in the unit test. ISO 8601 defines * Monday as the first day of the week. * week 01 is the week with the first Thursday Therefore: Sunday Dec 31st 2023 is the last day of the last week of the year : W52 2023.
JeanMeche
force-pushed
the
fix/week-iso
branch
from
d1c0c95
to
6af256d
Compare
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit 122213d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… year as intended in the unit tests.
This commit makes adds the mention to the doc that it is intended to return a ISO week/week-year (as opposed to a locale based wee/week-year).
ISO 8601 defines
Therefore:
Sunday Dec 31st 2023 is the last day of the last week of the year : W52 2023.
Fixes: #53813