-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): change defer block fixture default behavior to playthrough #54088
Conversation
63367e7
to
5a2c333
Compare
This is a followup to angular#53956 The default behavior needs to be changed in `TestBedCompiler` as well to have an effect.
5a2c333
to
49127fe
Compare
I'm confused. We should have already changed this in #53956. Update: Ah I see. I missed the test bed compiler change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -112,7 +112,7 @@ export class TestBedCompiler { | |||
private testModuleType: NgModuleType<any>; | |||
private testModuleRef: NgModuleRef<any>|null = null; | |||
|
|||
private deferBlockBehavior = DeferBlockBehavior.Manual; | |||
private deferBlockBehavior = DEFER_BLOCK_DEFAULT_BEHAVIOR; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is what we missed. Thanks for catching this.
This PR was merged into the repository by commit 037b79b. |
…angular#54088) This is a followup to angular#53956 The default behavior needs to be changed in `TestBedCompiler` as well to have an effect. PR Close angular#54088
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is a followup to #53956
I think the default behavior needs to be changed in
TestBedCompiler
as well to have an effect.I tested with v17.2.0-next.0, and the current default behavior is still
Manual
unless I missed something.What is the new behavior?
The default behavior is now
Playthrough
Does this PR introduce a breaking change?
Other information