fix(migrations): error in standalone migration when non-array value is used as declarations in TestBed #54122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s used as declarations in TestBed Adds some logic to skip over `TestBed.configureTestingModule` calls where the `declarations` aren't initialized to an array. We can't migrate these cases, because test migrations don't have access to the Angular compiler. Previously the migration would throw a runtime error.
crisbeto
added
action: review
crisbeto
commented
Jan 28, 2024
| isReferenceToImport(typeChecker, node.expression, catalystImport))) { | ||
| testObjects.push(node.arguments[0]); | ||
| ts.isObjectLiteralExpression(node.arguments[0]); | ||
| const config = isObjectLiteralCall ? node.arguments[0] as ts.ObjectLiteralExpression : null; |
There was a problem hiding this comment.
The logic is the same as before, I just moved it out into variables to be more readable.
devversion
approved these changes
Jan 28, 2024
crisbeto
added
action: merge
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 29, 2024
…s used as declarations in TestBed (#54122) Adds some logic to skip over `TestBed.configureTestingModule` calls where the `declarations` aren't initialized to an array. We can't migrate these cases, because test migrations don't have access to the Angular compiler. Previously the migration would throw a runtime error. PR Close #54122
|
This PR was merged into the repository by commit 28ad6fc. |
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
…s used as declarations in TestBed (angular#54122) Adds some logic to skip over `TestBed.configureTestingModule` calls where the `declarations` aren't initialized to an array. We can't migrate these cases, because test migrations don't have access to the Angular compiler. Previously the migration would throw a runtime error. PR Close angular#54122
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some logic to skip over
TestBed.configureTestingModulecalls where thedeclarationsaren't initialized to an array. We can't migrate these cases, because test migrations don't have access to the Angular compiler. Previously the migration would throw a runtime error.