Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Fix the template pipeline option #54148

Closed
wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Jan 29, 2024

The useTemplatePipeline option was not properly threaded through the component handler.

The `useTemplatePipeline` option was not properly threaded through the component handler.
@dylhunn dylhunn added area: compiler Issues related to `ngc`, Angular's template compiler compiler: template pipeline labels Jan 29, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 29, 2024
@dylhunn dylhunn added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 29, 2024
@dylhunn dylhunn marked this pull request as ready for review January 29, 2024 19:53
@alfaproject
Copy link
Contributor

Is there any documentation you can share about this feature or maybe a small summary with pros/cons and what the future holds? I'm open to give this feature a try in our projects to give early feedback if any but I'm curious to what I should be looking at

@dylhunn
Copy link
Contributor Author

dylhunn commented Jan 29, 2024

@alfaproject

The Template Pipeline is a brand new backend for the Angular compiler, replacing TemplateDefinitionBuilder and friends. It generates the Ivy instructions corresponding to an input template (or host binding). The Template Pipeline has an all-new design based on an intermediate representation compiled over many phases, which will allow us to experiment with compiler changes more easily in the future.

Users should experience no changes, since Template Pipeline produces almost-identical code to TemplateDefinitionBuilder. You can think of it as an internal-only change, which will hopefully allow us to build features such as Signal-based components faster.

We are adding this option for our own testing purposes, to ensure that there are no behavior changes in applications.

@alfaproject
Copy link
Contributor

@dylhunn I see, thank you for your reply!

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 29, 2024
@dylhunn
Copy link
Contributor Author

dylhunn commented Jan 29, 2024

caretaker: no g3 impact, and hand-tested when enabled

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 7b4d275.

nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
The `useTemplatePipeline` option was not properly threaded through the component handler.

PR Close angular#54148
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler compiler: template pipeline merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants