fix(router): Clear internal transition when navigation finalizes #54261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: patch
JoostK
approved these changes
Feb 5, 2024
atscott
added
action: merge
atscott
force-pushed
the
clearNavigationState
branch
from
3dc7d61
to
ae993ca
Compare
|
This PR was merged into the repository by commit 6681292. |
jessicajaniuk
pushed a commit
to jessicajaniuk/angular
that referenced
this pull request
Feb 7, 2024
…zes (angular#54261)" This reverts commit 6681292.
jessicajaniuk
pushed a commit
that referenced
this pull request
Feb 7, 2024
jessicajaniuk
pushed a commit
that referenced
this pull request
Feb 7, 2024
|
Sadly I had to revert this due to a G3 breakage. I'll ping you with the details. |
jessicajaniuk
added
state: blocked
and removed
action: merge
atscott
added
action: global presubmit
atscott
force-pushed
the
clearNavigationState
branch
from
c6f4b0a
to
2e353c4
Compare
This commit fixes a small memory issue in the router where a destroyed component instance would be retained. fixes angular#54241
atscott
force-pushed
the
clearNavigationState
branch
from
2e353c4
to
96d1db0
Compare
atscott
added
action: merge
|
This PR was merged into the repository by commit d3b273a. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a small memory issue in the router where a destroyed component instance would be retained.
fixes #54241