Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): expose queries as signals #54283

Closed
wants to merge 2 commits into from
Closed

feat(core): expose queries as signals #54283

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

This commit exposes authoring functions for queries as signals thus making those generally available.

@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Feb 6, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 6, 2024
@ngbot ngbot bot modified the milestone: Backlog Feb 6, 2024
atscott
atscott approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@JeanMeche JeanMeche mentioned this pull request Feb 6, 2024
Open
@pkozlowski-opensource
feat(core): expose queries as signals
3243192 
This commit exposes authoring functions for queries as signals
thus making those generally available.
@pkozlowski-opensource
test(core): enable signal queries tests with authoring
484d475 
Use signal queries tests with the authoring functions and without
decorators.
alxhub
alxhub approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

JoostK
JoostK approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 6, 2024
@pkozlowski-opensource
Copy link
Member Author

caretaker note: I believe that G3 presubmit is "green"

jessicajaniuk pushed a commit that referenced this pull request Feb 6, 2024
@pkozlowski-opensource @thePunderWoman
test(core): enable signal queries tests with authoring (#54283)
43de097 
Use signal queries tests with the authoring functions and without
decorators.

PR Close #54283
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 43de097.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@atscott atscott atscott approved these changes

@alxhub alxhub alxhub approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
v17.2 Candidates
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pkozlowski-opensource @jessicajaniuk @JoostK @atscott @alxhub @devversion