Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): interpolatedSignalNotInvoked diagnostic for model signals #54338

Closed

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The new model() signal introduces a ModelSignal type that needs to be handled by the interpolatedSignalNotInvoked diagnostic to catch issues like:

<div>{{ myModel }}</div>

What is the new behavior?

The diagnostic catches the issue

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto February 8, 2024 13:24
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 8, 2024
@jessicajaniuk jessicajaniuk added the area: compiler Issues related to `ngc`, Angular's template compiler label Feb 8, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 8, 2024
…signals

The new `model()` signal introduces a `ModelSignal` type that needs to be handled by the interpolatedSignalNotInvoked diagnostic to catch issues like:

```
<div>{{ myModel }}</div>
```
@jessicajaniuk jessicajaniuk force-pushed the fix/model-signal-interpolated-diag branch from b1896dc to e595bf9 Compare February 8, 2024 15:50
jessicajaniuk pushed a commit that referenced this pull request Feb 8, 2024
…signals (#54338)

The new `model()` signal introduces a `ModelSignal` type that needs to be handled by the interpolatedSignalNotInvoked diagnostic to catch issues like:

```
<div>{{ myModel }}</div>
```

PR Close #54338
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 38b01a3.

crisbeto added a commit to crisbeto/angular that referenced this pull request Feb 8, 2024
jessicajaniuk pushed a commit that referenced this pull request Feb 8, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants