fix(core): do not crash for signal query that does not have any matches #54353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.
JoostK
added
action: review
| for (let i = 0; i < tQueryMatches.length; i += 2) { | ||
| const tQueryMatches = tQuery.matches; | ||
| const result: Array<T|null> = []; | ||
| for (let i = 0; tQueryMatches !== null && i < tQueryMatches.length; i += 2) { |
There was a problem hiding this comment.
nit: how about an early exit after checking for tQueryMatches !== null?
There was a problem hiding this comment.
The empty array is assigned to lQuery.matches, so adjusting the control flow would get a bit awkward.
pkozlowski-opensource
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
LGTM, thnx @JoostK !
Left one nit commit, feel free to ignore.
pkozlowski-opensource
added
action: merge
pkozlowski-opensource
added
the
merge: caretaker note
|
caretaker note: I don't think G3 failure is related |
|
This PR was merged into the repository by commit abf6371. |
atscott
pushed a commit
to atscott/angular
that referenced
this pull request
Feb 16, 2024
…es (angular#54353) The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches. PR Close angular#54353
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals.
This commit addresses the crash by allowing there to be no matches.