Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support TypeScript 5.4 #54414

Closed
wants to merge 2 commits into from
Closed

feat(core): support TypeScript 5.4 #54414

wants to merge 2 commits into from
+1,098 −47

Conversation

crisbeto
Copy link
Member

Adds support for TypeScript 5.4 to the project.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited

Deployed aio for dd0e4cd to: https://ng-dev-previews-fw--pr-angular-angular-54414-aio-nr1pffhm.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited

Deployed adev-preview for 0d43aac to: https://ng-dev-previews-fw--pr-angular-angular-54414-adev-prev-q8whc8kk.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

crisbeto added a commit to crisbeto/angular that referenced this pull request Feb 17, 2024
@crisbeto
refactor(compiler-cli): add the ability to treat object literals as e…
41c8f55 
…nums in docs

We have a couple of cases now (angular#53753 and angular#54414) where we're forced to redefine enums as object literals. These literals aren't rendered in the best way in the docs so these changes introduce a new `object-literal-as-enum` tag that we can use to mark them so they're treated for documentation purposes.
@crisbeto crisbeto mentioned this pull request Feb 17, 2024
Closed
alxhub pushed a commit that referenced this pull request Feb 21, 2024
@crisbeto @alxhub
refactor(compiler-cli): add the ability to treat object literals as e…
f00336c 
…nums in docs (#54487)

We have a couple of cases now (#53753 and #54414) where we're forced to redefine enums as object literals. These literals aren't rendered in the best way in the docs so these changes introduce a new `object-literal-as-enum` tag that we can use to mark them so they're treated for documentation purposes.

PR Close #54487
alxhub pushed a commit that referenced this pull request Feb 21, 2024
@crisbeto @alxhub
refactor(compiler-cli): add the ability to treat object literals as e…
1d14e52 
…nums in docs (#54487)

We have a couple of cases now (#53753 and #54414) where we're forced to redefine enums as object literals. These literals aren't rendered in the best way in the docs so these changes introduce a new `object-literal-as-enum` tag that we can use to mark them so they're treated for documentation purposes.

PR Close #54487
@crisbeto crisbeto force-pushed the ts-5.4 branch 2 times, most recently from 5a76a3a to d8ee7cb Compare February 22, 2024 07:55
@crisbeto crisbeto marked this pull request as ready for review February 22, 2024 08:21
JeanMeche
JeanMeche reviewed Feb 22, 2024
View reviewed changes
packages/common/src/i18n/locale_data_api.ts
*/
export enum NumberSymbol {
export const NumberSymbol = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory this is a breaking change as enums allow to use the value as key.

How do we feel about it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't any usages of a backwards lookup in g3 so I'm inclined to say that this isn't common.

@crisbeto
Copy link
Member Author

Passing TGP, except for some pre-existing broken targets.

devversion
devversion approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noting the small change that may break downstream (but was discussed) that enum values are no longer possible keys for NumberSymbol.

AndrewKushnir
AndrewKushnir approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott February 23, 2024 21:37
atscott
atscott approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@crisbeto
feat(core): support TypeScript 5.4
fb887b5 
Adds support for TypeScript 5.4 to the project.
@crisbeto
fix(compiler-cli): account for as expression in docs extraction
dd0e4cd 
Fixes that the extraction for `object-literal-as-enum` didn't account for constants initialized to an `as` expression.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Feb 24, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Feb 27, 2024

This PR was merged into the repository by commit 12dc4d0.

@dylhunn dylhunn closed this in 9749589 Feb 27, 2024
dylhunn pushed a commit that referenced this pull request Feb 27, 2024
@crisbeto @dylhunn
fix(compiler-cli): account for as expression in docs extraction (#54414)
12dc4d0 
Fixes that the extraction for `object-literal-as-enum` didn't account for constants initialized to an `as` expression.

PR Close #54414
@arjenbrandenburgh arjenbrandenburgh mentioned this pull request Mar 14, 2024
Open
14 tasks
@ssams ssams mentioned this pull request Mar 27, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@atscott atscott atscott approved these changes

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview aio: preview detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crisbeto @dylhunn @atscott @JeanMeche @devversion @AndrewKushnir