fix(compiler-cli): fix broken version detection condition #54443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version detection condition for signal two-way bindings used an OR instead of an AND, resulting in every `.0` patch version being considered as supporting two-way bindings to signals. This commit fixes the logic and adds additional parentheses to ensure the meaning of the condition is more clear. Long term, we should switch to semver version parsing instead.
alxhub
added
action: merge
AndrewKushnir
approved these changes
Feb 14, 2024
AndrewKushnir
added
action: presubmit
|
This PR was merged into the repository by commit 9ca8c68. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Feb 14, 2024
The version detection condition for signal two-way bindings used an OR instead of an AND, resulting in every `.0` patch version being considered as supporting two-way bindings to signals. This commit fixes the logic and adds additional parentheses to ensure the meaning of the condition is more clear. Long term, we should switch to semver version parsing instead. PR Close #54443
| @@ -799,8 +799,8 @@ export class NgCompiler { | |||
| // two-way bindings. We also allow version 0.0.0 in case somebody is using Angular at head. | |||
There was a problem hiding this comment.
What is the usage of 'Angular at head'? Sorry, I googled and couldn't find the relevant info.
There was a problem hiding this comment.
Inside google apps use the version available in the monorepo, which is the head.
atscott
pushed a commit
to atscott/angular
that referenced
this pull request
Feb 16, 2024
) The version detection condition for signal two-way bindings used an OR instead of an AND, resulting in every `.0` patch version being considered as supporting two-way bindings to signals. This commit fixes the logic and adds additional parentheses to ensure the meaning of the condition is more clear. Long term, we should switch to semver version parsing instead. PR Close angular#54443
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Feb 20, 2024
) The version detection condition for signal two-way bindings used an OR instead of an AND, resulting in every `.0` patch version being considered as supporting two-way bindings to signals. This commit fixes the logic and adds additional parentheses to ensure the meaning of the condition is more clear. Long term, we should switch to semver version parsing instead. PR Close angular#54443
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version detection condition for signal two-way bindings used an OR instead of an AND, resulting in every
.0patch version being considered as supporting two-way bindings to signals.This commit fixes the logic and adds additional parentheses to ensure the meaning of the condition is more clear. Long term, we should switch to semver version parsing instead.