fix(core): properly execute content queries for root components #54457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found. This is a pre-existing bug, introduction of signal-based queries just surfaced it. Fixes angular#54450
pkozlowski-opensource
added
action: review
pkozlowski-opensource
added
the
target: patch
crisbeto
approved these changes
Feb 15, 2024
| @@ -56,8 +58,6 @@ import {selectIndexInternal} from './advance'; | |||
| import {ɵɵdirectiveInject} from './di'; | |||
| import {handleUnknownPropertyError, isPropertyValid, matchingSchemas} from './element_validation'; | |||
| import {writeToDirectiveInput} from './write_to_directive_input'; | |||
| import { AttributeMarker } from '../interfaces/attribute_marker'; | |||
| import { InputFlags } from '../interfaces/input_flags'; | |||
There was a problem hiding this comment.
Weird that these got reformatted 🤔 not a blocker for the change though.
There was a problem hiding this comment.
Yeh, I run my editor with organize imports + format on save. So organize imports made it flagged as "changed" and the formatter did the rest :-)
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit d9a1a7d. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Feb 15, 2024
Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found. This is a pre-existing bug, introduction of signal-based queries just surfaced it. Fixes #54450 PR Close #54457
atscott
pushed a commit
to atscott/angular
that referenced
this pull request
Feb 16, 2024
…lar#54457) Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found. This is a pre-existing bug, introduction of signal-based queries just surfaced it. Fixes angular#54450 PR Close angular#54457
JeanMeche
pushed a commit
to JeanMeche/angular
that referenced
this pull request
Feb 20, 2024
…lar#54457) Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found. This is a pre-existing bug, introduction of signal-based queries just surfaced it. Fixes angular#54450 PR Close angular#54457
JeanMeche
pushed a commit
to JeanMeche/angular
that referenced
this pull request
Feb 20, 2024
…lar#54457) Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found. This is a pre-existing bug, introduction of signal-based queries just surfaced it. Fixes angular#54450 PR Close angular#54457
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Feb 20, 2024
…lar#54457) Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found. This is a pre-existing bug, introduction of signal-based queries just surfaced it. Fixes angular#54450 PR Close angular#54457
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix an incorrect view instance (a dynamically created component one instead of the root view) was passed to the content query function. Having incorrect view instance meant that a component instance could not be found.
This is a pre-existing bug, introduction of signal-based queries just surfaced it.
Fixes #54450