fix(compiler-cli): identify aliased initializer functions #54480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
aliased-init-fn
branch
from
c7e27bd
to
8f55367
Compare
crisbeto
commented
Feb 16, 2024
| * Tracks which symbols are imported in specific files and under what names. | ||
| * Allows for efficient querying for references to those symbols. | ||
| */ | ||
| export class ImportedSymbolsTracker { |
There was a problem hiding this comment.
In the future I think we'll also need methods like hasImportsFor(symbol, moduleName) and hasNamespaceImportFor(moduleName) which will allow us to skip traversing the entire file even earlier. I skipped them for now since we don't need them yet, but all the information is already there.
crisbeto
force-pushed
the
aliased-init-fn
branch
3 times, most recently
from
0911967
to
1132572
Compare
crisbeto
force-pushed
the
aliased-init-fn
branch
from
1132572
to
7e8a3c5
Compare
devversion
approved these changes
Feb 22, 2024
packages/compiler-cli/src/ngtsc/imports/src/imported_symbols_tracker.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/imports/src/imported_symbols_tracker.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/imports/src/imported_symbols_tracker.ts
Outdated
Show resolved
Hide resolved
| const transformers: ts.CustomTransformers = { | ||
| before: [ | ||
| getInitializerApiJitTransform(reflectionHost, /* isCore */ false), | ||
| getInitializerApiJitTransform(reflectionHost, importTracker, /* isCore */ false), |
There was a problem hiding this comment.
At this point we have so many trackers 😄 local compilation, deferred etc
Fixes that initializer functions weren't being recognized if they are aliased (e.g. `import {model as alias} from '@angular/core';`).
To do this efficiently, I had to introduce the `ImportedSymbolsTracker` which scans the top-level imports of a file and allows them to be checked quickly, without having to go through the type checker. It will be useful in the future when verifying that that initializer APIs aren't used in unexpected places.
I've also introduced tests specifically for the `tryParseInitializerApiMember` function so that we can test it in isolation instead of going through the various functions that call into it.
crisbeto
force-pushed
the
aliased-init-fn
branch
from
7e8a3c5
to
096bbd2
Compare
crisbeto
added
action: merge
|
This PR was merged into the repository by commit f04ecc0. |
dylhunn
pushed a commit
that referenced
this pull request
Feb 23, 2024
Fixes that initializer functions weren't being recognized if they are aliased (e.g. `import {model as alias} from '@angular/core';`).
To do this efficiently, I had to introduce the `ImportedSymbolsTracker` which scans the top-level imports of a file and allows them to be checked quickly, without having to go through the type checker. It will be useful in the future when verifying that that initializer APIs aren't used in unexpected places.
I've also introduced tests specifically for the `tryParseInitializerApiMember` function so that we can test it in isolation instead of going through the various functions that call into it.
PR Close #54480
Closed
dylhunn
added a commit
to dylhunn/angular
that referenced
this pull request
Feb 23, 2024
…gular#54480)" This reverts commit f04ecc0.
|
Rolled back due to breakage in g3. In summary, |
dylhunn
added a commit
that referenced
this pull request
Feb 26, 2024
dylhunn
added a commit
that referenced
this pull request
Feb 26, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that initializer functions weren't being recognized if they are aliased (e.g.
import {model as alias} from '@angular/core';).To do this efficiently, I had to introduce the
ImportedSymbolsTrackerwhich scans the top-level imports of a file and allows them to be checked quickly, without having to go through the type checker. It will also be useful in the future when verifying that that initializer APIs aren't used in unexpected places.I've also introduced tests specifically for the
tryParseInitializerApiMemberfunction so that we can test it in isolation instead of going through the various functions that call into it.