Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): image placeholder not removed in OnPush component #54515

Closed
wants to merge 1 commit into from
Closed

fix(common): image placeholder not removed in OnPush component #54515

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes that the placeholder wasn't being removed when an optimized image is placed in an OnPush component.

Fixes #54478.

@crisbeto
fix(common): image placeholder not removed in OnPush component
91ea662 
Fixes that the placeholder wasn't being removed when an optimized image is placed in an `OnPush` component.

Fixes angular#54478.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Feb 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 20, 2024
AndrewKushnir
AndrewKushnir approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisbeto thanks for the fix 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 20, 2024
@alxhub
Copy link
Member

alxhub commented Feb 20, 2024

This PR was merged into the repository by commit 219445c.

alxhub pushed a commit that referenced this pull request Feb 20, 2024
@crisbeto @alxhub
fix(common): image placeholder not removed in OnPush component (#54515)
d34e329 
Fixes that the placeholder wasn't being removed when an optimized image is placed in an `OnPush` component.

Fixes #54478.

PR Close #54515
@alxhub alxhub closed this in 219445c Feb 20, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Styles are not updated correctly after image loaded by NgOptimizedImage (with OnPush Change Detection)
3 participants
@crisbeto @alxhub @AndrewKushnir