-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migrations): Fix cf migration regular expression to include underscores #54533
Conversation
e651c1c
to
4354700
Compare
…scores In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration. fixes: angular#54532
4354700
to
577fa46
Compare
|
||
writeFile('/comp.html', [ | ||
`<div *ngIf="show">show</div>`, | ||
`<a-very-long-component-name-that-has_underscores-too`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
This PR was merged into the repository by commit 42d3ddd. |
@stefhorst if you run into problems with 17.2.2 please open a dedicated issue with a minimal reproduction scenario. You are commenting on a PR that has nothing to do with routing. |
OK sorry |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?