feat(router): Add reusable types for router guards #54580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: minor
atscott
force-pushed
the
guardReturnTypes
branch
from
07b1e89
to
2d4002f
Compare
This refactor makes it easier to update the return types of guards. Rather than having to track what types guards can return, which may change with new features over time, `MaybeAsync<GuardResult>` can be used instead.
atscott
force-pushed
the
guardReturnTypes
branch
from
2d4002f
to
5465d36
Compare
AndrewKushnir
approved these changes
Feb 27, 2024
dylhunn
approved these changes
Feb 28, 2024
pkozlowski-opensource
added
the
merge: caretaker note
|
caretaker note: pullapprove is wrong here, this PR has necessary approvals, merging. |
|
This PR was merged into the repository by commit c1c7384. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor makes it easier to update the return types of guards. Rather than having to track what types guards can return, which may change with new features over time,
MaybeAsync<GuardResult>can be used instead.Reviewer note: This is a separate
featcommit from #45023. Doing this in a commit ahead of time makes it possible to adjust internal code ahead of the breaking change that adds a type to theGuardResult. This means code can be made forward-compatible first and #45023 can be merged without needing to include updates to internal code at the same time the sync happens.