fix(compiler-cli): unwrap expressions with type parameters in query read property #54647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead property
Fixes that a query like `viewChild('locator', {read: ElementRef<HTMLElement>})` would throw because we didn't account for expressions with type parameters.
I've also included support for parenthesized expressions and `as` expressions since it's pretty easy to support them.
Fixes angular#54645.
pkozlowski-opensource
added
action: review
devversion
approved these changes
Feb 28, 2024
crisbeto
added
action: merge
|
This PR was merged into the repository by commit ae7dbe4. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Feb 28, 2024
…ead property (#54647) Fixes that a query like `viewChild('locator', {read: ElementRef<HTMLElement>})` would throw because we didn't account for expressions with type parameters. I've also included support for parenthesized expressions and `as` expressions since it's pretty easy to support them. Fixes #54645. PR Close #54647
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that a query like
viewChild('locator', {read: ElementRef<HTMLElement>})would throw because we didn't account for expressions with type parameters.I've also included support for parenthesized expressions and
asexpressions since it's pretty easy to support them.Fixes #54645.