Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): apply TestBed provider overrides to @defer dependencies #54667

Closed
wants to merge 1 commit into from
Closed

fix(core): apply TestBed provider overrides to @defer dependencies #54667

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates TestBed logic to take into account situations when dependencies loaded within @defer blocks may import NgModules with providers. For such components, we invoke provider override function, which recursively inspects and applies the necessary changes.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: defer Issues related to @defer blocks. labels Mar 1, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 1, 2024
@AndrewKushnir
fix(core): apply TestBed provider overrides to @defer dependencies
8adcfb6 
This commit updates TestBed logic to take into account situations when dependencies loaded within `@defer` blocks may import NgModules with providers. For such components, we invoke provider override function, which recursively inspects and applies the necessary changes.
@AndrewKushnir
Copy link
Contributor Author

Exploratory presubmit.

jessicajaniuk
jessicajaniuk approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 4, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 33a6fab.

pkozlowski-opensource pushed a commit that referenced this pull request Mar 5, 2024
@AndrewKushnir @pkozlowski-opensource
fix(core): apply TestBed provider overrides to @defer dependencies (#…
586cc24 
…54667)

This commit updates TestBed logic to take into account situations when dependencies loaded within `@defer` blocks may import NgModules with providers. For such components, we invoke provider override function, which recursively inspects and applies the necessary changes.

PR Close #54667
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: defer Issues related to @defer blocks. target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndrewKushnir @pkozlowski-opensource @jessicajaniuk