Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): return a readonly signal on asReadonly. #54719

Closed
wants to merge 1 commit into from
Closed

fix(core): return a readonly signal on asReadonly. #54719

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Backport of #54706 for patch

@JeanMeche
fix(core): return a readonly signal on asReadonly.
4843304 
Previous `asReadonly()` returned the signal value and not the signal itself.

Fixes angular#54704
@JeanMeche JeanMeche added area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Mar 6, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 6, 2024
@JeanMeche JeanMeche mentioned this pull request Mar 6, 2024
Closed
@JeanMeche JeanMeche marked this pull request as ready for review March 6, 2024 13:58
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Mar 6, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 443e5f1.

pkozlowski-opensource pushed a commit that referenced this pull request Mar 6, 2024
@JeanMeche @pkozlowski-opensource
fix(core): return a readonly signal on asReadonly. (#54719)
443e5f1 
Previous `asReadonly()` returned the signal value and not the signal itself.

Fixes #54704

PR Close #54719
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeanMeche @pkozlowski-opensource