fix(compiler): not catching for loop empty tracking expressions #54772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the template parser wasn't catching empty expressions in the `track` parameter of for loops. Fixes angular#54763.
crisbeto
added
action: review
crisbeto
commented
Mar 8, 2024
| @@ -1520,6 +1520,11 @@ describe('R3 template transform', () => { | |||
| @case {case} | |||
| } | |||
| `)).toThrowError(/@case block must have exactly one parameter/); | |||
| expect(() => parse(` | |||
| @switch (cond) { | |||
| @case ( ) {case} | |||
There was a problem hiding this comment.
I added some extra tests for switches and conditionals, but they didn't have this problem.
|
Thank you @crisbeto ! |
dylhunn
approved these changes
Mar 11, 2024
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 81ccf5d. |
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the template parser wasn't catching empty expressions in the
trackparameter of for loops.Fixes #54763.