Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(common): request low quality placeholder images #54899

Closed
wants to merge 1 commit into from
Closed

refactor(common): request low quality placeholder images #54899

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Mar 15, 2024 •
edited

For every built-in loader, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.

@AndrewKushnir AndrewKushnir requested review from kara and AndrewKushnir and removed request for jessicajaniuk March 16, 2024 04:58
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release common: image directive labels Mar 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 16, 2024
kara
kara approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some typos to fix in comments

packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts Outdated Show resolved Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts Outdated Show resolved Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts Outdated Show resolved Hide resolved
@JeanMeche JeanMeche force-pushed the refactor/image-placeholder-quality branch from 19fd9d7 to e1a5995 Compare March 23, 2024 04:13
AndrewKushnir
AndrewKushnir approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just added a couple minor comments.

packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts Outdated Show resolved Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/constants.ts Show resolved Hide resolved
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 23, 2024
@JeanMeche
refactor(common): request low quality placeholder images
743cc35 
For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.
@JeanMeche JeanMeche force-pushed the refactor/image-placeholder-quality branch from e1a5995 to 743cc35 Compare March 23, 2024 05:46
AndrewKushnir
AndrewKushnir approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche thanks for addressing the feedback 👍

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 23, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 24, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 25, 2024

This PR was merged into the repository by commit ee3bb81.

@dylhunn dylhunn closed this in ee3bb81 Mar 25, 2024
dylhunn pushed a commit that referenced this pull request Mar 25, 2024
@JeanMeche @dylhunn
refactor(common): request low quality placeholder images (#54899)
4bb332e 
For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.

PR Close #54899
Jefftopia added a commit to Jefftopia/angular that referenced this pull request Mar 26, 2024
@Jefftopia
fix(common): skip transfer cache on client
4c1b4a5 
transfer cache interceptor should not run again on the client as it is intended for server to client handoff

Squashed commit of the following:

commit 0dbeb44
Merge: a8d132a ee3bb81
Author: Jeffrey Smith <jsmith6690@gmail.com>
Date:   Mon Mar 25 17:51:23 2024 -0400

    Merge branch 'main' of https://github.com/angular/angular into feat/skip-transfer-cache-browser

commit ee3bb81
Author: Matthieu Riegler <kyro38@gmail.com>
Date:   Fri Mar 15 21:27:55 2024 +0100

    refactor(common): request low quality placeholder images (angular#54899)

    For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.

    PR Close angular#54899

commit 13554f9
Author: Alan Agius <alanagius@google.com>
Date:   Thu Mar 21 14:17:03 2024 +0000

    fix(http): manage different body types for caching POST requests (angular#54980)

    This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality.

    Closes angular#54956

    PR Close angular#54980

commit b2ba945
Author: Matthieu Riegler <kyro38@gmail.com>
Date:   Sat Mar 23 23:30:54 2024 -0700

    docs: unescape html entities (angular#55016)

    adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.

    PR Close angular#55016

commit 9dabef0
Author: Andrea Canciani <ranma42@gmail.com>
Date:   Sun Mar 24 10:38:34 2024 +0100

    test(zone.js): fix zone.js test listener removal (angular#55017)

    The test was checking the wrong set of listeners because of a typo.

    PR Close angular#55017

commit 6f8b48a
Author: Jeffrey Smith <jsmith6690@gmail.com>
Date:   Sat Mar 23 12:29:41 2024 -0400

    feat(common): skip transfer cache on client

    transfer cache interceptor should not run again on the client as it is intended for server to client handoff
@JeanMeche JeanMeche deleted the refactor/image-placeholder-quality branch March 26, 2024 03:06
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@JeanMeche @ilirbeqirii
refactor(common): request low quality placeholder images (angular#54899)
39263fa 
For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.

PR Close angular#54899
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package common: image directive target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeanMeche @AndrewKushnir @dylhunn @kara