Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added note about toSignal #54996

Closed
wants to merge 1 commit into from

Conversation

ApplY3D
Copy link
Contributor

@ApplY3D ApplY3D commented Mar 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #54995

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott March 22, 2024 10:32
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 22, 2024
Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change. LGTM.

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 25, 2024
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should also be made to the a.dev guide: adev/src/content/guide/signals/rxjs-interop.md

@ApplY3D
Copy link
Contributor Author

ApplY3D commented Mar 25, 2024

Thank you, adev changed.
I'd like to point out that there's a difference in the wording between aio and adev.
Screenshot 2024-03-25 at 21 20 24

@JeanMeche JeanMeche requested a review from atscott March 26, 2024 03:04
@atscott
Copy link
Contributor

atscott commented Mar 26, 2024

Thank you, adev changed. I'd like to point out that there's a difference in the wording between aio and adev. Screenshot 2024-03-25 at 21 20 24

That’s fine. The wording on adev feels better to me. Aio is in maintenance mode at the moment. Updates will not always be reflected there.

@dylhunn dylhunn added the target: major This PR is targeted for the next major release label Mar 27, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 27, 2024

This PR was merged into the repository by commit 3650b37.

@dylhunn dylhunn closed this in 3650b37 Mar 27, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: docs Related to the documentation target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants