fix(service-worker): remove controllerchange listener when app is destroyed
#55365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/service-worker-rm-controllerchange
branch
from
551c1c4
to
0cbfb5a
Compare
pkozlowski-opensource
added
the
area: service-worker
arturovt
force-pushed
the
fix/service-worker-rm-controllerchange
branch
from
0cbfb5a
to
2b09325
Compare
arturovt
force-pushed
the
fix/service-worker-rm-controllerchange
branch
from
2b09325
to
299013b
Compare
There was a problem hiding this comment.
@arturovt thanks for the fix! The code looks great, just added 1 minor comment.
AndrewKushnir
added
action: review
…estroyed This commit updates the `ngswAppInitializer` implementation and removes the `controllerchange` listener upon the destruction of the `ApplicationRef`. This adjustment aims to prevent memory leaks. In a zone.js environment, neglecting to do so could lead to the perpetual creation of a zone task, which captures the zone and obstructs proper garbage collection.
arturovt
force-pushed
the
fix/service-worker-rm-controllerchange
branch
from
299013b
to
aba98f7
Compare
AndrewKushnir
approved these changes
May 21, 2024
AndrewKushnir
added
action: merge
|
Caretaker note: this change is low-risk, no additional reviews are required, this PR is ready for merge. |
dylhunn
added
target: rc
|
It looks like this has merge conflicts with 17.3. I'm going to put it in v18 only; feel free to send a patch port if you want it in 17.3.x. |
|
This PR was merged into the repository by commit afe4561. |
dylhunn
pushed a commit
that referenced
this pull request
May 21, 2024
…estroyed (#55365) This commit updates the `ngswAppInitializer` implementation and removes the `controllerchange` listener upon the destruction of the `ApplicationRef`. This adjustment aims to prevent memory leaks. In a zone.js environment, neglecting to do so could lead to the perpetual creation of a zone task, which captures the zone and obstructs proper garbage collection. PR Close #55365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
ngswAppInitializerimplementation and removes thecontrollerchangelistener upon the destruction of theApplicationRef. This adjustment aims to prevent memory leaks. In a zone.js environment, neglecting to do so could lead to the perpetual creation of a zone task, which captures the zone and obstructs proper garbage collection.