Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Throw a runtime error if both zone and zoneless are p… #55410

Closed
wants to merge 1 commit into from
Closed

refactor(core): Throw a runtime error if both zone and zoneless are p… #55410

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 18, 2024

…rovided

This commit adds a dev-mode error if both the zone and zoneless providers are used together.

@atscott atscott added the target: minor This PR is targeted for the next minor release label Apr 18, 2024
@atscott atscott requested a review from alxhub April 18, 2024 22:14
@atscott atscott force-pushed the errorOnZoneAndZoneless branch 3 times, most recently from 83220fd to 8a76b42 Compare April 22, 2024 19:16
pkozlowski-opensource
pkozlowski-opensource reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

pkozlowski-opensource
pkozlowski-opensource approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 24, 2024
@pkozlowski-opensource
Copy link
Member

LGTM but needs a bit of cleanup (error verifications failing)

@ngbot ngbot bot removed this from the v18 feature freeze candidates milestone Apr 24, 2024
thePunderWoman
thePunderWoman approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 24, 2024
@AndrewKushnir AndrewKushnir removed their request for review April 26, 2024 23:14
@AndrewKushnir AndrewKushnir added this to the v18 final milestone Apr 26, 2024
@ngbot ngbot bot removed this from the v18 final milestone Apr 26, 2024
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label Apr 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2024
@atscott
refactor(core): Throw a runtime error if both zone and zoneless are p…
1d7bc27 
…rovided

This commit adds a dev-mode error if both the zone and zoneless
providers are used together.
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels May 7, 2024
@AndrewKushnir AndrewKushnir removed the request for review from alxhub May 7, 2024 20:37
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit abbaf8f.

AndrewKushnir pushed a commit that referenced this pull request May 7, 2024
@atscott @AndrewKushnir
refactor(core): Throw a runtime error if both zone and zoneless are p…
9eb7478 
…rovided (#55410)

This commit adds a dev-mode error if both the zone and zoneless
providers are used together.

PR Close #55410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atscott @pkozlowski-opensource @AndrewKushnir @thePunderWoman