refactor(core) Remove enums from event-dispatch. #55421
Open
+126
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
added
the
requires: TGP
iteriani
force-pushed
the
enumsbegone
branch
2 times, most recently
from
9b3c939
to
fea4093
Compare
rahatarmanahmed
approved these changes
Apr 19, 2024
| */ | ||
| SKIP_A11Y_CHECK = 'a11ysc', | ||
| } | ||
| export const Attribute = { |
There was a problem hiding this comment.
I think we can delete this now
(also these aren't really Attributes)
There was a problem hiding this comment.
Is it ok to do in a followup change?
AndrewKushnir
approved these changes
Apr 19, 2024
pullapprove
bot
requested review from
atscott,
pkozlowski-opensource and
thePunderWoman
thePunderWoman
approved these changes
Apr 22, 2024
iteriani
force-pushed
the
enumsbegone
branch
4 times, most recently
from
127d9f2
to
5d168fc
Compare
iteriani
changed the title
pkozlowski-opensource
removed request for
josephperrott,
atscott,
pkozlowski-opensource and
dylhunn
thePunderWoman
added
area: core
thePunderWoman
added
the
action: review
AndrewKushnir
approved these changes
May 7, 2024
These cause optimization issues in external.
thePunderWoman
approved these changes
May 8, 2024
|
TESTED=TGP |
iteriani
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cause optimization issues in external.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information