fix(common): execute checks when image is already loaded #55444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/ng-optimize-complete-state
branch
3 times, most recently
from
8edc403
to
0d687eb
Compare
With this commit, we're now able to perform checks even when the image has already been loaded (e.g., from the browser cache), and its `load` event would never be triggered. We utilize the [complete](https://html.spec.whatwg.org/#dom-img-complete) property, as specified, which indicates that the image state is fully available when the user agent has retrieved all the image data. This approach effectively triggers checks, as we no longer solely rely on the `load` event and consider that the image may already be loaded. Additionally, it helps prevent memory leaks in development mode, as `load` and `error` event listeners will still be attached to the image element.
arturovt
force-pushed
the
fix/ng-optimize-complete-state
branch
from
0d687eb
to
b224ebd
Compare
AndrewKushnir
requested review from
kara and
AndrewKushnir
and removed request for
dylhunn
AndrewKushnir
added
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, we're now able to perform checks even when the image has already been loaded (e.g., from the browser cache), and its
loadevent would never be triggered. We utilize the complete property, as specified, which indicates that the image state is fully available when the user agent has retrieved all the image data. This approach effectively triggers checks, as we no longer solely rely on theloadevent and consider that the image may already be loaded. Additionally, it helps prevent memory leaks in development mode, asloadanderrorevent listeners will still be attached to the image element.