Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate core to prettier formatting #55488

Closed
wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

Migrate formatting to prettier for core from clang-format

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 23, 2024
@josephperrott josephperrott force-pushed the reformat-core branch 2 times, most recently from 528c432 to 388aa41 Compare April 23, 2024 16:24
@josephperrott josephperrott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 23, 2024
@josephperrott
Copy link
Member Author

Caretaker Note: this will require the merging of cl/627414906 for internal syncing.

@alxhub
Copy link
Member

alxhub commented Apr 23, 2024

Blocking this until after the feature freeze at least (and we should consider until rc0 goes out), as it would invalidate too many open PRs.

@josephperrott josephperrott force-pushed the reformat-core branch 2 times, most recently from 4a29437 to 82a7218 Compare April 23, 2024 20:19
Migrate formatting to prettier for core from clang-format
@josephperrott josephperrott added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note state: blocked labels Apr 29, 2024
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Apr 29, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 31fdf0f.

AndrewKushnir pushed a commit that referenced this pull request Apr 29, 2024
Migrate formatting to prettier for core from clang-format

PR Close #55488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants