fix(compiler): maintain multiline CSS selectors during CSS scoping #55509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
alan-agius4
added
requires: TGP
alan-agius4
force-pushed
the
sm-fix
branch
4 times, most recently
from
933ade0
to
ee07635
Compare
alan-agius4
removed
the
action: global presubmit
Previously, multiline selectors were being converted into single lines, resulting in sourcemap disruptions due to shifts in line numbers. Closes angular#55508
alan-agius4
added
the
action: review
crisbeto
approved these changes
May 2, 2024
| @@ -658,8 +658,8 @@ export class ShadowCss { | |||
|
|
|||
| private _scopeSelector(selector: string, scopeSelector: string, hostSelector: string): string { | |||
| return selector | |||
| .split(',') | |||
| .map((part) => part.trim().split(_shadowDeepSelectors)) | |||
| .split(/ ?, ?/) | |||
There was a problem hiding this comment.
Should we use \s here rather than an actual space?
There was a problem hiding this comment.
No otherwise the newlines will get lost which would cause the sourcemaps to break.
alan-agius4
added
action: merge
AndrewKushnir
added
the
merge: caretaker note
|
Caretaker note: looks like this PR might have some risk in g3, will proceed with the merge on Monday, 05/06. |
|
This PR was merged into the repository by commit 3e1d6e9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, multiline selectors were being converted into single lines, resulting in sourcemap disruptions due to shifts in line numbers.
Closes #55508