Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core) Move action resolution into a standalone class. #55523

Closed
wants to merge 1 commit into from
Closed

refactor(core) Move action resolution into a standalone class. #55523

wants to merge 1 commit into from

Conversation

tbondwilkinson
Copy link
Contributor

@tbondwilkinson tbondwilkinson commented Apr 24, 2024 •
edited

This refactor will enable moving this functionality into the dispatcher.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Code is located in EventContract

Issue Number: N/A

What is the new behavior?

Code is located in ActionResolver

Does this PR introduce a breaking change?

  • Yes
  • No

iteriani
iteriani reviewed Apr 24, 2024
View reviewed changes
packages/core/primitives/event-dispatch/src/action_resolver.ts Outdated
@@ -0,0 +1,352 @@
import {EventContract} from './eventcontract';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests for this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing eventcontract_test spec would cover the same, since it's used by EventContract

@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-events branch 3 times, most recently from 4b4a19c to f8756ae Compare April 24, 2024 23:20
@iteriani iteriani self-requested a review April 24, 2024 23:23
@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-events branch 4 times, most recently from dd2d566 to 23b7d79 Compare April 30, 2024 16:24
@tbondwilkinson
Copy link
Contributor Author

tbondwilkinson commented Apr 30, 2024 •
edited

TESTED=TGP

@tbondwilkinson tbondwilkinson added area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release core: event dispatch labels Apr 30, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 30, 2024
@tbondwilkinson tbondwilkinson added requires: TGP This PR requires a passing TGP before merging is allowed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2024
@tbondwilkinson tbondwilkinson marked this pull request as ready for review April 30, 2024 16:45
@pullapprove pullapprove bot requested a review from alxhub April 30, 2024 16:45
@tbondwilkinson
Copy link
Contributor Author

Caretaker note: Patch cl/629442272 into sync CL for updates to internal BUILD rules.

thePunderWoman
thePunderWoman approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, primitives

@tbondwilkinson tbondwilkinson force-pushed the jsaction-custom-events branch 2 times, most recently from 8bc2073 to 1b79ac0 Compare April 30, 2024 20:35
@tbondwilkinson
refactor(core): Move action resolution into a standalone class.
333c63c 
This refactor will enable moving this functionality into the dispatcher.
@tbondwilkinson tbondwilkinson added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2024
@AndrewKushnir AndrewKushnir changed the title refactor(core:) Move action resolution into a standalone class. refactor(core) Move action resolution into a standalone class. Apr 30, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 5903c37.

tbondwilkinson added a commit to tbondwilkinson/angular that referenced this pull request May 1, 2024
@tbondwilkinson
refactor(core): Move action resolution into a standalone class. (angu…
aac26b5 
…lar#55523)

This refactor will enable moving this functionality into the dispatcher.

PR Close angular#55523
AndrewKushnir pushed a commit that referenced this pull request May 1, 2024
@tbondwilkinson @AndrewKushnir
refactor(core): Move action resolution into a standalone class. (#55523…
4837621 
…) (#55621)

This refactor will enable moving this functionality into the dispatcher.

PR Close #55523

PR Close #55621
@tbondwilkinson tbondwilkinson deleted the jsaction-custom-events branch May 6, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@iteriani iteriani iteriani approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tbondwilkinson @AndrewKushnir @thePunderWoman @iteriani