refactor(core): Ensure animations are flushed before running render hooks #55564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
the
requires: TGP
pullapprove
bot
removed
area: core
atscott
added
area: core
pullapprove
bot
removed
target: rc
atscott
force-pushed
the
unrevert
branch
2 times, most recently
from
bb4fbc7
to
96b9ea5
Compare
atscott
added
the
requires: TGP
pullapprove
bot
removed
the
requires: TGP
atscott
force-pushed
the
unrevert
branch
2 times, most recently
from
2561855
to
cf9545e
Compare
atscott
changed the title
atscott
force-pushed
the
unrevert
branch
3 times, most recently
from
be29d6b
to
12c1877
Compare
atscott
added
action: merge
thePunderWoman
approved these changes
Apr 29, 2024
JeanMeche
added
action: cleanup
|
@atscott FYI, this PR has conflicts with the |
…ooks This commit ensures we flush animations by calling renderFactory begin/end in cases where the ApplicationRef._tick happens in a mode that skips straight to the render hooks.
atscott
added
action: merge
AndrewKushnir
added
the
target: rc
|
This PR was merged into the repository by commit 024e9bf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures we flush animations by calling renderFactory
begin/end in cases where the ApplicationRef._tick happens in a mode that
skips straight to the render hooks.
Reviewer note: This is a partial roll-forward of 964074a. It doesn't solve the problem of unflushed animations when there are no more views but does simplify the scheduler notification WRT animations (there's no special notification in the animation code now).