docs: Reference page anchor scroll consistency #55566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs-viewer loads asynchronously and can happen after the scroll event has happened and the Router has attempted to scroll to the requested position/anchor. This commit saves the scroll event and handles it again if the cards are loaded after scrolling happens.
atscott
added
target: patch
|
Deployed adev-preview for 6131f65 to: https://ng-dev-previews-fw--pr-angular-angular-55566-adev-prev-rdxzz8fs.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
approved these changes
Apr 26, 2024
|
This PR was merged into the repository by commit 99cf450. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2024
The docs-viewer loads asynchronously and can happen after the scroll event has happened and the Router has attempted to scroll to the requested position/anchor. This commit saves the scroll event and handles it again if the cards are loaded after scrolling happens. PR Close #55566
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2024
The docs-viewer loads asynchronously and can happen after the scroll event has happened and the Router has attempted to scroll to the requested position/anchor. This commit saves the scroll event and handles it again if the cards are loaded after scrolling happens. PR Close #55566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs-viewer loads asynchronously and can happen after the scroll event has happened and the Router has attempted to scroll to the requested position/anchor. This commit saves the scroll event and handles it again if the cards are loaded after scrolling happens.
Example: https://angular.dev/api/router/Router#dispose (refreshing this page a bunch of times sometimes scrolls to the
disposemethod and other times does not)