Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): don't schedule timer triggers on the server #55605

Closed
wants to merge 1 commit into from
Closed

fix(core): don't schedule timer triggers on the server #55605

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 1, 2024

Fixes that even though we weren't rendering the deferred block the server, we were still triggering the timeout which can delay the response.

Fixes #55475.

@crisbeto
fix(core): don't schedule timer triggers on the server
17204f2 
Fixes that even though we weren't rendering the deferred block the server, we were still triggering the timeout which can delay the response.

Fixes angular#55475.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels May 1, 2024
@ngbot ngbot bot modified the milestone: Backlog May 1, 2024
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 1, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 1, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit a0ec2d8.

AndrewKushnir pushed a commit that referenced this pull request May 1, 2024
@crisbeto @AndrewKushnir
fix(core): don't schedule timer triggers on the server (#55605)
3818436 
Fixes that even though we weren't rendering the deferred block the server, we were still triggering the timeout which can delay the response.

Fixes #55475.

PR Close #55605
AndrewKushnir pushed a commit that referenced this pull request May 1, 2024
@crisbeto @AndrewKushnir
fix(core): don't schedule timer triggers on the server (#55605)
36130b2 
Fixes that even though we weren't rendering the deferred block the server, we were still triggering the timeout which can delay the response.

Fixes #55475.

PR Close #55605
This was referenced May 17, 2024
Open
Open
Open
This was referenced May 29, 2024
Merged
Merged
@ambrose40 ambrose40 mentioned this pull request May 29, 2024
Open
@aminekun90 aminekun90 mentioned this pull request May 30, 2024
Open
@Rosenstein Rosenstein mentioned this pull request May 31, 2024
Merged
This was referenced May 31, 2024
Open
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Bug in @placeholder block causing delay in server-side rendering
2 participants
@crisbeto @AndrewKushnir