Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): move back all xterm code to the fw repo #55642

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented May 2, 2024

Previously, the @angular/docs package had xterm as dependency but wasn't referencing it. It only had dedicated styles. This commit moves back the styles to the FW repo as it is only used here.

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 2, 2024
@ngbot ngbot bot added this to the Backlog milestone May 2, 2024
@JeanMeche JeanMeche marked this pull request as ready for review May 13, 2024 16:04
@pullapprove pullapprove bot requested a review from devversion May 13, 2024 16:04
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the Sass is the same? (if not, we should get additional review)

package.json Outdated Show resolved Hide resolved
adev/angular.json Outdated Show resolved Hide resolved
Previously, the `@angular/docs` package had `xterm` as dependency but wasn't referencing it. It only had dedicated styles. This commit moves back the styles to the FW repo as it is only used here.
Copy link

Deployed adev-preview for b5026f6 to: https://ng-dev-previews-fw--pr-angular-angular-55642-adev-prev-glleris6.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 29, 2024
thePunderWoman pushed a commit that referenced this pull request May 30, 2024
Previously, the `@angular/docs` package had `xterm` as dependency but wasn't referencing it. It only had dedicated styles. This commit moves back the styles to the FW repo as it is only used here.

PR Close #55642
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 7928e11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants