fix(core): tree shake dev mode error message #57035
Closed
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
57034/to-signal-error
branch
from
3e5875e to
55c415b
Compare
JoostK
reviewed
Jul 18, 2024
crisbeto
force-pushed
the
57034/to-signal-error
branch
from
55c415b to
9567497
Compare
JeanMeche
reviewed
Jul 18, 2024
Adds an `ngDevMode` check before a runtime error message. Fixes angular#57034.
crisbeto
force-pushed
the
57034/to-signal-error
branch
from
9567497 to
bf423ef
Compare
| @@ -205,10 +206,10 @@ export function toSignal<T, U = undefined>( | |||
| throw current.error; | |||
| case StateKind.NoValue: | |||
| // This shouldn't really happen because the error is thrown on creation. | |||
| // TODO(alxhub): use a RuntimeError when we finalize the error semantics | |||
| throw new ɵRuntimeError( | |||
There was a problem hiding this comment.
nit: sounds like a repeated code - would it make sense to pull it out into a utility function?
There was a problem hiding this comment.
I think the only repeated code is half of the if statement (kind === StateKind.NoValue)and thethrow new RuntimeError` so I'm not sure it's worth it.
There was a problem hiding this comment.
Yeh, but I'm not thrilled about having the error message in 2 places.
pkozlowski-opensource
approved these changes
Jul 22, 2024
crisbeto
added
action: merge
|
This PR was merged into the repository by commit fe41b11. The changes were merged into the following branches: main, 18.1.x |
atscott
pushed a commit
that referenced
this pull request
Jul 22, 2024
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
Adds an `ngDevMode` check before a runtime error message. Fixes angular#57034. PR Close angular#57035
ShahriarMalik
pushed a commit
to ShahriarMalik/angular
that referenced
this pull request
Jul 30, 2024
Adds an `ngDevMode` check before a runtime error message. Fixes angular#57034. PR Close angular#57035
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ngDevModecheck before a runtime error message.