Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide real standalone providers #3503

Merged
merged 3 commits into from May 14, 2024

Conversation

robertIsaac
Copy link
Contributor

usage before
importProvidersFrom(provideFirebaseApp(() => initializeApp(...)))

usage now
provideFirebaseApp(() => initializeApp(...))

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

usage before
`importProvidersFrom(provideFirebaseApp(() => initializeApp(...)))`

usage now
`provideFirebaseApp(() => initializeApp(...))`
@robertIsaac
Copy link
Contributor Author

@jamesdaniels @davideast
can you take a look at the PR?

@jamesdaniels
Copy link
Member

@robertIsaac appreciated, will take a look shortly

@ginagr
Copy link

ginagr commented Apr 1, 2024

Hi! Any updates on when this PR can be expected to be merged?

@jamesdaniels jamesdaniels merged commit 4d322f9 into angular:master May 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants