Skip to content

Commit

Permalink
build: disable strict attribute type checking
Browse files Browse the repository at this point in the history
We are temporarily disabling strict attribute type checking
since we have a few templates that set a coerced input while
the `NgModel` directive is applied. In those cases, the empty string
for the `disabled` input, is not assignable to the `NgModel#disabled` input,
since it does not do coercion. We need to figure out what to do in those
scenarios.
  • Loading branch information
devversion committed Oct 30, 2019
1 parent 31f19bd commit 5e696c1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/bazel/postinstall-patches.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ searchAndReplace(`[formatProperty + "_ivy_ngcc"]`, '[formatProperty]',
searchAndReplace(/angular_compiler_options = {/, `$&
"strictTemplates": True,
"strictDomLocalRefTypes ": False,
"strictAttributeTypes": False,
"strictDomEventTypes": False,`, 'node_modules/@angular/bazel/src/ng_module.bzl');

/**
Expand Down

0 comments on commit 5e696c1

Please sign in to comment.