Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDC-based checkbox & radio click targets are too small #22991

Closed
jelbourn opened this issue Jun 16, 2021 · 1 comment · Fixed by #22994
Closed

MDC-based checkbox & radio click targets are too small #22991

jelbourn opened this issue Jun 16, 2021 · 1 comment · Fixed by #22994
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/checkbox area: material/radio P2 The issue is important to a large percentage of users, with a workaround
Projects
Accessibility 2021

Comments

@jelbourn
Copy link
Member

Our MDC-based checkbox and radio have click targets at 40px × 40px instead of 48 × 48px. Slide-toggle is already good here.

Fix for checkbox is already open in #22892
@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) has pr area: material/checkbox area: material/radio labels Jun 16, 2021
@crisbeto crisbeto self-assigned this Jun 16, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 16, 2021
@crisbeto
fix(material-experimental/mdc-radio): add accessible touch targets
71ffaef 
Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in angular#22892.

Fixes angular#22991.
@crisbeto crisbeto mentioned this issue Jun 16, 2021
Merged
@jelbourn jelbourn added this to In progress (review, presubmit) in Accessibility 2021 Jun 21, 2021
@jelbourn jelbourn moved this from In progress (review, presubmit) to Failing presubmit in Accessibility 2021 Jun 21, 2021
Accessibility 2021 automation moved this from Failing presubmit to Done Jun 22, 2021
mmalerba pushed a commit that referenced this issue Jun 22, 2021
@crisbeto
fix(material-experimental/mdc-radio): add accessible touch targets (#…
150d5af 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.
mmalerba pushed a commit that referenced this issue Jun 22, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-radio): add accessible touch targets (#…
6074fd1 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

(cherry picked from commit 150d5af)
mmalerba pushed a commit that referenced this issue Jun 22, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-radio): add accessible touch targets (#…
041f582 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

(cherry picked from commit 150d5af)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/checkbox area: material/radio P2 The issue is important to a large percentage of users, with a workaround
Projects
Accessibility 2021
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material-experimental/mdc-radio): add accessible touch targets crisbeto/material2
2 participants
@jelbourn @crisbeto